Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug build fix #961

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Debug build fix #961

merged 1 commit into from
Apr 20, 2024

Conversation

rodlie
Copy link
Contributor

@rodlie rodlie commented Apr 18, 2024

Fix broken debug build introduced in b134344

@rodlie rodlie mentioned this pull request Apr 19, 2024
Merged
acolwell
acolwell approved these changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@acolwell acolwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry about this. I wonder why this didn't get caught by the CI build. It is supposed to be doing a debug build as well as a release build.

@rodlie
Copy link
Contributor Author

rodlie commented Apr 20, 2024

The reason was that CMake never did a debug build, see #963

@rodlie rodlie merged commit b1a5210 into NatronGitHub:RB-2.5 Apr 20, 2024
3 checks passed
@rodlie rodlie deleted the RB-2.5-buildfix branch April 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolwell acolwell acolwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodlie @acolwell