-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Openexr 3.2 #931
Upgrade to Openexr 3.2 #931
Conversation
@@ -0,0 +1,56 @@ | |||
# Maintainer: Miloš Komarčević <miloskomarcevic@aim.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this and the patch above just a copy of what is in the MINGW repo? If so, then I don't think we should maintain our own copy and build a Natron specific version. If this isn't a copy, what have you changed from the MINGW version and why?
@@ -70,7 +69,6 @@ build() { | |||
-DBUILD_SHARED_LIBS=ON \ | |||
-DBUILD_TESTING=OFF \ | |||
-DOPENEXR_INSTALL_EXAMPLES=OFF \ | |||
-DOPENEXR_INSTALL_PKG_CONFIG=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this and the OPENEXR_BUILD_TOOLS=OFF logic above being removed? Are then no longer needed/defined in the new version of OPENEXR?
Closing since #942 updated the version of OpenEXR and had been merged. |
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
OpenEXR 3.2.1 has fixes for libdeflate (a.k.a. DEFLATE with a zlib wrapper)
Have you tested your changes (if applicable)? If so, how?
Created a Windows release build with these new library versions and it appears to work fine.