Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Openexr 3.2 #931

Conversation

360highdynamicrangehdr
Copy link

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

OpenEXR 3.2.1 has fixes for libdeflate (a.k.a. DEFLATE with a zlib wrapper)

Have you tested your changes (if applicable)? If so, how?

Created a Windows release build with these new library versions and it appears to work fine.

@@ -0,0 +1,56 @@
# Maintainer: Miloš Komarčević <miloskomarcevic@aim.com>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this and the patch above just a copy of what is in the MINGW repo? If so, then I don't think we should maintain our own copy and build a Natron specific version. If this isn't a copy, what have you changed from the MINGW version and why?

@@ -70,7 +69,6 @@ build() {
-DBUILD_SHARED_LIBS=ON \
-DBUILD_TESTING=OFF \
-DOPENEXR_INSTALL_EXAMPLES=OFF \
-DOPENEXR_INSTALL_PKG_CONFIG=ON \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this and the OPENEXR_BUILD_TOOLS=OFF logic above being removed? Are then no longer needed/defined in the new version of OPENEXR?

@acolwell
Copy link
Collaborator

acolwell commented Feb 1, 2024

Closing since #942 updated the version of OpenEXR and had been merged.

@acolwell acolwell closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants