Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs and add support for UNC paths on Windows. #901

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Fix bugs and add support for UNC paths on Windows. #901

merged 2 commits into from
Sep 11, 2023

Commits on Aug 22, 2023

  1. Minor cleanup of SequenceFileDialog and FileSystemModel 

    - Added helper functions to reduce redundant code, improve readability,
  and help clarify intent.

- Added getSplitPath() and cleanPath() to FileSystemModel to make it
  easier to test and extend this functionality.

- Added unit tests for some FileSystemModel functions to document
  existing behavior and make it easier to see how behavior changes
  with bug fixes.

- Deleted unused code.
    @acolwell
    acolwell committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0a232e3 View commit details
    Browse the repository at this point in the history

  2. Fix bugs and add support for UNC paths on Windows. 

    - Added code to detect network share paths on Windows and
  treat make them behave like drives.

- Fixed a bug where paths typed in with lower case drive
  letters would cause an upper case drive AND a lower
  case drive entry to appear in the "My Computer" view.
  A similar thing would happen for network share hostnames.
  Added logic to upper case the drive letter and hostnames
  as part of the "path cleanup" logic. This causes the
  paths to map to single entries in the "My Computer" view.

- Fixed an infinite loop during directory restore when
  a non-existant network share was specified in a previous
  Open File dialog instance.

- Fixed "up" button so that it behaves more consistently
  and properly handles network share paths.

- Fixed invalid memory access for files that start with a '.'

- Fixed a few places where code was using a URL path instead
  of converting the URL to a local path string like the
  vast majority of the code. This made it possible to properly
  view the root directory of network shares.

- Updated unit tests to reflect changes in path handling
  behaviour.
    @acolwell
    acolwell committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    238eacd View commit details
    Browse the repository at this point in the history