Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 4161 - Fix TRex dataframe cleanup function #4162

Open
wants to merge 1 commit into
base: release/10.4
Choose a base branch
from

Conversation

4gt-104
Copy link

@4gt-104 4gt-104 commented Sep 26, 2024

Fix 'clean_df' function in 'trex/df_preprocessing.py' module which misbehaves not selecting any existing columns to delete in order to cleanup dataframe for visualization.

Resolves: #4161

Fix 'clean_df' function in 'trex/df_preprocessing.py' module
which misbehaves not selecting any existing columns to delete
in order to cleanup dataframe for visualization.

Resolves: NVIDIA#4161
Signed-off-by: Tigran Grigoryan <grigoryan.tigran119@gmail.com>
@4gt-104
Copy link
Author

4gt-104 commented Sep 26, 2024

I am not sure to which branch the change should be merged as I have not found any information regarding experimental subprojects in CONTRIBUTING.md.

@netaz
Copy link

netaz commented Oct 6, 2024

Thanks @4gt-104! - the fix looks correct but I want to test it before merging, and it will take me a little while to get to it.
Note that TRT's backend is rapidly changing and a lot of the features offered by the TREX API will stop being useful soon, if not already.
The chief reason is that TRT performs much more aggressive fusions and the grouping and accounting of operations is not feasible. I will need to rework the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRex package contains functions that do not work as expected.
2 participants