Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xspress3 support with the community IOC #46

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

mrakitin
Copy link
Member

@mrakitin mrakitin commented Nov 27, 2023

We with @dmgav made the first pass with the community IOC ophyd classes from the nslsii package, and it worked with some manual preparation. Need to address the following items:

TODOs:

  • Set up TTL Veto mode and number of points in the external trigger mode.
  • Fix the shapes dynamically:
     xs.fluor.shape = (121, 8, 4096)
     xs.fluor.describe()
     Out[2]:
     {'fluor': {'source': 'SIM:fluor',
      'dtype': 'array',
      'shape': (121, 8, 4096),
      'external': 'FILESTORE:',
      'dtype_str': 'uint32',
      'dims': ('bin_count',)}}
  • Sort out the wrong shape (251, 4, 4096) - it was related to the xs.fluor.name = "fluor" change. Without the change, it worked OK. We may still want to investigate where this change affects the shape change as PyXRF uses this fluor field for data access.

@mrakitin mrakitin marked this pull request as ready for review December 12, 2023 19:06
@mrakitin
Copy link
Member Author

mrakitin commented Feb 1, 2024

I think we can merge the PR. The CI issues are due to some unclear timeouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant