Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII Histograms #45

Merged
merged 20 commits into from
Aug 16, 2023
Merged

ASCII Histograms #45

merged 20 commits into from
Aug 16, 2023

Conversation

mjgleason
Copy link
Collaborator

This PR introduces a new CLI command reView-tools histogram, which can be used to plot a histogram for one or more supply curve columns directly in the terminal. A basic form of the command looks like:

reView-tools histogram supply-curve-wind.csv -c area_sq_km -c capacity_mw

And returns:
histogram_screen_cap

As shown above, multiple columns can be plotted with a single command. Other optional arguments for the command enable explicitly setting the plot width and height, as well as the number of bins.

@mjgleason mjgleason self-assigned this Aug 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Patch coverage: 86.88% and project coverage change: +8.14% 🎉

Comparison is base (cdd9594) 39.65% compared to head (fe32827) 47.80%.
Report is 96 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   39.65%   47.80%   +8.14%     
==========================================
  Files          45       47       +2     
  Lines        3929     4621     +692     
  Branches      665      723      +58     
==========================================
+ Hits         1558     2209     +651     
- Misses       2344     2376      +32     
- Partials       27       36       +9     
Flag Coverage Δ
unittests 47.80% <86.88%> (+8.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
reView/layout/layout.py 100.00% <ø> (ø)
reView/pages/rev/controller/selection.py 18.84% <ø> (ø)
setup.py 0.00% <0.00%> (ø)
...nario_page/test_controller/test_chart_callbacks.py 100.00% <ø> (ø)
reView/components/map.py 21.60% <5.55%> (-0.13%) ⬇️
reView/utils/functions.py 34.93% <28.00%> (-0.11%) ⬇️
reView/pages/rev/controller/callbacks.py 22.55% <29.16%> (+0.46%) ⬆️
reView/utils/config.py 86.74% <33.33%> (-1.06%) ⬇️
reView/utils/plots.py 87.50% <87.50%> (ø)
reView/cli.py 94.79% <97.67%> (+6.56%) ⬆️
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and simple, nice work Mike. A few comments but they're minor

reView/utils/plots.py Outdated Show resolved Hide resolved
reView/cli.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@WilliamsTravis WilliamsTravis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@mjgleason mjgleason merged commit 867f7e4 into main Aug 16, 2023
4 checks passed
@mjgleason mjgleason deleted the ascii_plots branch August 16, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants