-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASCII Histograms #45
ASCII Histograms #45
Conversation
…ne to use a similarity score rather than strict equality for slight differences between terminal, debug termal, other OSs etc
…tests for histogram, fixing issue with unit tests for histogram
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 39.65% 47.80% +8.14%
==========================================
Files 45 47 +2
Lines 3929 4621 +692
Branches 665 723 +58
==========================================
+ Hits 1558 2209 +651
- Misses 2344 2376 +32
- Partials 27 36 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean and simple, nice work Mike. A few comments but they're minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
This PR introduces a new CLI command
reView-tools histogram
, which can be used to plot a histogram for one or more supply curve columns directly in the terminal. A basic form of the command looks like:And returns:
As shown above, multiple columns can be plotted with a single command. Other optional arguments for the command enable explicitly setting the plot width and height, as well as the number of bins.