Update JGDAS ENKF SELECT OBS JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs #3092
Conversation
mingshichen-noaa
requested review from
RussTreadon-NOAA,
CoryMartin-NOAA and
CatherineThomas-NOAA
as code owners
mingshichen-noaa
removed request for
CoryMartin-NOAA,
RussTreadon-NOAA and
CatherineThomas-NOAA
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mingshichen-noaa
requested review from
WalterKolczynski-NOAA,
KateFriedman-NOAA and
DavidHuber-NOAA
There was a problem hiding this comment.
looks good. I am no longer familiar w/ the IN and OUT of EnKF related data, so would appreciate a review from @CatherineThomas-NOAA @RussTreadon-NOAA
aerorahul
requested review from
RussTreadon-NOAA,
CatherineThomas-NOAA and
DavidGrumm-NOAA
WalterKolczynski-NOAA
added
the
CI-Hera-Ready
emcbot
removed
the
CI-Hera-Ready
|
@aerorahul @WalterKolczynski-NOAA @KateFriedman-NOAA |
|
@mingshichen-noaa Since this PR now also includes COM updates for the analysis job, please update the PR title and description to reflect the file changeset. Thanks! |
mingshichen-noaa
changed the title
There was a problem hiding this comment.
COM updates look good, thanks @mingshichen-noaa ! Approve pending successful completion of CI testing.
|
@aerorahul @KateFriedman-NOAA @AntonMFernando-NOAA |
@mingshichen-noaa Thanks for checking on this! Since the change for the eobs job requires companion updates to the analysis/analysis_calc jobs at the same time then it was necessary to submit the changes together. Hopefully @AntonMFernando-NOAA hasn't already done much work on those job scripts. :) In the future, I suggest checking the spreadsheet sooner if you think you need to update other job scripts at the same time. If someone else has already assigned themself to that job then you should reach out to them to say you can take care of it within your work or collaborate with the other developer if they have already begun making changes. Hope that helps! |
|
@mingshichen-noaa please update the COM update tracking spreadsheet to reflect the analysis/analysis_calc job updates, thanks! |
|
@KateFriedman-NOAA |
|
@KateFriedman-NOAA @AntonMFernando-NOAA |
|
@KateFriedman-NOAA |
mingshichen-noaa
removed request for
RussTreadon-NOAA,
CatherineThomas-NOAA,
DavidGrumm-NOAA and
GeorgeGayno-NOAA
WalterKolczynski-NOAA
removed
the
CI-Hera-Failed
Did you figure it out @mingshichen-noaa ? I see pushes from develop into your PR branch. |
|
@KateFriedman-NOAA |
| [[ -d "${COM_ATMOS_ANALYSIS}" ]] || mkdir -p "${COM_ATMOS_ANALYSIS}" | ||
| [[ -d "${COM_ATMOS_RESTART}" ]] || mkdir -p "${COM_ATMOS_RESTART}" | ||
| [[ -d "${COMOUT_ATMOS_ANALYSIS}" ]] || mkdir -p "${COMOUT_ATMOS_ANALYSIS}" | ||
| [[ -d "${COMIN_ATMOS_RESTART}" ]] || mkdir -p "${COMIN_ATMOS_RESTART}" |
There was a problem hiding this comment.
Shouldn't be creating an input directory.
| [[ -d "${COMIN_ATMOS_RESTART}" ]] || mkdir -p "${COMIN_ATMOS_RESTART}" |
Description
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jgdas enkf select obs job and relevant .JGLOBAL_ATMOS_ANALYSIS and JGLOBAL_ATMOS_ANALYSIS_CALC jobs.
Refs #2451
Type of change
Change characteristics
How has this been tested?
Checklist