Add variable rescaling for aerosol species #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aerosol species. Does not yet include a way to read the values in from a yaml or config file.
…nd multply with stddev file.
CoryMartin-NOAA
approved these changes
Nov 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for additions to chem_diagb.h that could allow for a variable rescaling (rs) for each aerosol species. It does not yet include a way to read the values in from a yaml or config file. The it compiles and runs, but I have not yet tested it using 3dvar. And it still has lots of print statements used for testing. It runs in about 40 seconds at C96, and is probably slowed down by the print statements. Any comments will be helpful.
Also, note the if statement. I was unsure of the dimensions of an array, so I put in a test. I'll remove it along with the print statements.