Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom DOI field in load_csv #97

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Jul 31, 2024

This PR adds a custom DOI field option to load custom format CSVs. Added a test case for this as well.

In addition, a minor bug with calling strptime is fixed (it called the module, not the class inside the module which holds the method).

Tests pass on my machine, except two Semantic Scholar tests. I didn't touch that part, so I assume those failures are unrelated.

This allows us to load the Retraction Watch csv database. An example of that format is provided with the test case.
@egpbos egpbos requested a review from stijnh July 31, 2024 13:34
@stijnh stijnh merged commit f1a6079 into NLeSC:master Jul 31, 2024
5 checks passed
@stijnh
Copy link
Member

stijnh commented Jul 31, 2024

LGTM!

Not sure why the SemanticScholar tests fail, they seem to run fine on the CI

To use this change, install the dev version of litstudy:

pip install git+https://github.com/NLeSC/litstudy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants