Skip to content

Commit

Permalink
cran comments and bump version
Browse files Browse the repository at this point in the history
  • Loading branch information
sda030 committed Sep 17, 2024
1 parent c116521 commit c1ef3cc
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: saros.base
Title: Base Tools for Semi-Automatic Reporting of Ordinary Surveys
Version: 0.2.0
Version: 0.2.1
Authors@R: c(
person(given = "Stephan",
family = "Daus",
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# saros.base 0.2.0
# saros.base 0.2.1

* CRAN release.
12 changes: 5 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
## R CMD check results

0 errors | 0 warnings | 2 notes
0 errors | 0 warnings | 4 notes

## Note

- Retry on a new release. Spellchecking is correct. URLs are correct (will be valid upon release).
- Response to Beni regarding comment: "You submitted 3 packages which probably are only used together? Please consider to ship one package and not several if these will typically be updated at the same time. If you want to keep them seperated please let us know and we will publish them (or wait for your resubmission if needed)."
- We have multiple reasons for the decoupling (reasons below). However, instead of saros, saros.base, saros.utils, and saros.contents we managed to compress them into two: saros and saros.base (this). We must keep some separation because:
1) Reducing dependencies and thus fragility of the packages.
2) Despite the 'saros' prefix, they are meant to work completely independently from each other, and will likely receive different maintenance needs (saros.base is most stable, saros.contents has many expansions in the pipeline, and saros.utils contains a mix of useful, experimental, and temporary features - some which should be submitted in 3rd party packages at a later stage).
3) The packages have different target users: A newbie report author should only need saros, whereas the data cleaner/editor would only need saros.base.
- Fixed return values docs and removed write-by-default.
- Remaining cat() use is merely for writing to disk (main purpose of functions) or if log file has been specified (defaults to off).
- URLs are correct (will be valid upon release).
- rhub fails for MacOS-R-devel due to failure in building RApiSerialize 0.1.3. I have waited to see if it magically got fixed but to no avail. Pretty sure there is nothing I can do on my end, as all other runs succeed.

0 comments on commit c1ef3cc

Please sign in to comment.