Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reload error happened on zh-tw corse information page #205

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

ntut-xuan
Copy link
Collaborator

@ntut-xuan ntut-xuan commented Oct 21, 2023

Description

See: #203

Fix the issue by changing the index:

  • Note should be 19.
  • ScheduleHref should be 18.

How to Verify?

  • Check the error message won't happen on the application w/ zh-TW language.
  • Check the error message won't happen on the application w/ en-US language.
  • Check the index should be correct. (See screen)

Screenshots/GIF/Test Results (Optional)

image image image

Copy link
Collaborator

@James-Lu-none James-Lu-none left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comfirmed that a column was reduced and cause the method "getTWCourseMainInfoList" error due to accessing array "nodesOne" out of range.

  • Check the error message won't happen on the application w/ zh-TW language.
  • Check the error message won't happen on the application w/ en-US language.
  • Check the index should be correct. (See screen)

@ntut-xuan ntut-xuan modified the milestones: 1.4.4, 1.4.5 Oct 21, 2023
@ntut-xuan ntut-xuan merged commit b1a48a8 into master Oct 21, 2023
5 of 8 checks passed
@ntut-xuan ntut-xuan deleted the 203-course-information-reload-error branch October 21, 2023 17:38
@ntut-xuan ntut-xuan mentioned this pull request Oct 23, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants