修復「讀取學生列表時出現大量延遲」的問題 (#231)

* Implement: Loading Text * Fix: Loading Twice * Chore: Format
NEO-TAT · Mar 1, 2024 · ef45e69 · ef45e69
1 parent b11f6be
commit ef45e69
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 14 deletions.
diff --git a/lib/generated/intl/messages_en.dart b/lib/generated/intl/messages_en.dart
@@ -146,6 +146,8 @@ class MessageLookup extends MessageLookupByLibrary {
         "getScoreRankError": MessageLookupByLibrary.simpleMessage("There\'s an error getting the grades"),
         "getScoreRankQuestionnaireError": MessageLookupByLibrary.simpleMessage(
             "There\'s an error getting the grades.\nPlease check if the Online Course Evaluation Questionnaire has been completed"),
+        "getStudentList": MessageLookupByLibrary.simpleMessage("Getting student list..."),
+        "getStudentListError": MessageLookupByLibrary.simpleMessage("Getting student list error"),
         "github": MessageLookupByLibrary.simpleMessage("Github"),
         "graduationSetting": MessageLookupByLibrary.simpleMessage("Graduation credit standard setting"),
         "historicalDimension": MessageLookupByLibrary.simpleMessage("Historical dimension"),

diff --git a/lib/generated/intl/messages_zh_TW.dart b/lib/generated/intl/messages_zh_TW.dart
@@ -141,6 +141,8 @@ class MessageLookup extends MessageLookupByLibrary {
         "getScoreRank": MessageLookupByLibrary.simpleMessage("取得成績中..."),
         "getScoreRankError": MessageLookupByLibrary.simpleMessage("取得成績錯誤"),
         "getScoreRankQuestionnaireError": MessageLookupByLibrary.simpleMessage("取得成績錯誤，請確認期末教學評量是否填寫完成"),
+        "getStudentList": MessageLookupByLibrary.simpleMessage("取得修課名單..."),
+        "getStudentListError": MessageLookupByLibrary.simpleMessage("取得修課名單錯誤"),
         "github": MessageLookupByLibrary.simpleMessage("Github"),
         "graduationSetting": MessageLookupByLibrary.simpleMessage("畢業學分標準設定"),
         "historicalDimension": MessageLookupByLibrary.simpleMessage("歷史向度"),

diff --git a/lib/generated/l10n.dart b/lib/generated/l10n.dart
diff --git a/lib/l10n/intl_en.arb b/lib/l10n/intl_en.arb
@@ -62,6 +62,8 @@
   "getScoreRankQuestionnaireError": "There's an error getting the grades.\nPlease check if the Online Course Evaluation Questionnaire has been completed",
   "getCalendar": "Getting calendar...",
   "getCalendarError": "Getting calendar error",
+  "getStudentList": "Getting student list...",
+  "getStudentListError": "Getting student list error",
   "deleteMessage": "Deleting message...",
   "deleteMessageError": "Delete error",
   "loginNTUTApp": "Login to the NTUTApp...",

diff --git a/lib/l10n/intl_zh_TW.arb b/lib/l10n/intl_zh_TW.arb
@@ -62,6 +62,8 @@
   "getScoreRankQuestionnaireError": "取得成績錯誤，請確認期末教學評量是否填寫完成",
   "getCalendar": "取得行事曆中...",
   "getCalendarError": "取得行事曆錯誤",
+  "getStudentList": "取得修課名單...",
+  "getStudentListError": "取得修課名單錯誤",
   "deleteMessage": "刪除訊息中...",
   "deleteMessageError": "刪除錯誤",
   "loginNTUTApp": "登入北科助理...",

diff --git a/lib/src/task/iplus/iplus_get_course_student_list_task.dart b/lib/src/task/iplus/iplus_get_course_student_list_task.dart
@@ -12,21 +12,21 @@ import 'iplus_system_task.dart';
 class IPlusGetStudentListTask extends IPlusSystemTask<List<CourseStudent>> {
   String courseId;
 
-  IPlusGetStudentListTask({required this.courseId}) : super("IPlusCourseAnnouncementTask");
+  IPlusGetStudentListTask({required this.courseId}) : super("IPlusGetStudentListTask");
 
   @override
   Future<TaskStatus> execute() async {
     final status = await super.execute();
     if (status == TaskStatus.success) {
-      super.onStart(R.current.getISchoolPlusCourseAnnouncement);
+      super.onStart(R.current.getStudentList);
       final value = await ISchoolPlusConnector.getCourseStudent(courseId);
       super.onEnd();
       switch (value.status) {
         case IPlusReturnStatus.success:
           result = value.result;
           return TaskStatus.success;
         case IPlusReturnStatus.fail:
-          return super.onError(R.current.getISchoolPlusCourseAnnouncementError);
+          return super.onError(R.current.getStudentListError);
         case IPlusReturnStatus.noPermission:
           final parameter = MsgDialogParameter(
             title: R.current.warning,

diff --git a/lib/ui/pages/coursedetail/screen/course_info_page.dart b/lib/ui/pages/coursedetail/screen/course_info_page.dart
@@ -42,7 +42,6 @@ class _CourseInfoPageState extends State<CourseInfoPage> with AutomaticKeepAlive
     super.initState();
     isLoading = true;
     BackButtonInterceptor.add(myInterceptor);
-    Future.microtask(() => _loadCourseStudent());
     Future.delayed(Duration.zero, () {
       _addTask();
     });
@@ -228,16 +227,6 @@ class _CourseInfoPageState extends State<CourseInfoPage> with AutomaticKeepAlive
     return <String, String>{};
   }
 
-  void _loadCourseStudent() async {
-    TaskFlow taskFlow = TaskFlow();
-    final courseMainInfo = widget.courseInfo.main;
-    final task = IPlusGetStudentListTask(courseId: courseMainInfo.course.id);
-    taskFlow.addTask(task);
-    if (await taskFlow.start()) {
-      task.result;
-    }
-  }
-
   String getDepartment(Map<String, String> departmentMap, String studentId) {
     /*
       * Since we don't have official data to describe the following hard-coded rule is correct.