-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UFS-dev PR#220 #1096
Merged
Merged
UFS-dev PR#220 #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added hflx_fire and evap_fire to GFS_surface_composite_post * added cpl_fire flag
* added fsmoke tracer * added surface emissions to fsmoke in rrfs_smoke_wrapper
Fixes Intel LLVM compiler (ifx) error: physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(237): error #8284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type character or is an element of an array that is not assumed shape, pointer, or polymorphic. [SIG1T] CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, & -----------^
grantfirl
requested review from
Qingfu-Liu,
dustinswales,
haiqinli,
barlage,
cenlinhe,
tanyasmirnova,
SamuelTrahanNOAA,
JongilHan66,
joeolson42,
gthompsnWRF,
RuiyuSun,
AndersJensen-NOAA,
AnningCheng-NOAA,
andrewgettelman,
lisa-bengtsson and
mzhangw
as code owners
October 18, 2024 21:16
grantfirl
removed request for
andrewgettelman,
barlage,
joeolson42,
gthompsnWRF,
haiqinli,
tanyasmirnova and
SamuelTrahanNOAA
October 18, 2024 21:16
grantfirl
requested review from
rhaesung,
mkavulich and
climbfuji
and removed request for
RuiyuSun,
cenlinhe,
JongilHan66,
AnningCheng-NOAA,
lisa-bengtsson and
AndersJensen-NOAA
October 18, 2024 21:16
Merged
dustinswales
approved these changes
Oct 22, 2024
Resolves #1003 |
climbfuji
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good, fixes #1003 and we are very much looking forward to using ifx
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains changes from ufs-community#193 and ufs-community#220