Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#220 #1096

Merged
merged 9 commits into from
Oct 22, 2024
Merged

UFS-dev PR#220 #1096

merged 9 commits into from
Oct 22, 2024

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 18, 2024

Contains changes from ufs-community#193 and ufs-community#220

masih-e and others added 7 commits October 18, 2024 10:56
* added hflx_fire and evap_fire to GFS_surface_composite_post
* added cpl_fire flag
* added fsmoke tracer
* added surface emissions to fsmoke in rrfs_smoke_wrapper
Fixes Intel LLVM compiler (ifx) error:

physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(237): error #8284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type character or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
@grantfirl grantfirl requested review from climbfuji and removed request for climbfuji October 22, 2024 19:09
@climbfuji
Copy link
Collaborator

Resolves #1003

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good, fixes #1003 and we are very much looking forward to using ifx.

@grantfirl grantfirl merged commit cdc11de into NCAR:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler crash in physics/aerinterp.F90 with Intel oneAPI compilers (ifx)
5 participants