Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to explore various values of AED and LD. #93

Merged

Conversation

mahesh-panchal
Copy link
Collaborator

@mahesh-panchal mahesh-panchal commented Sep 25, 2023

Adds parameters to allow for a parameter sweep across values of AED and locus distance. Closes #57

Changes the params.enable_conda to conda.enabled. Closes #94


Additionally fixes other workflows broken by module updates and other nf-core tweeks.


Tests run:

nextflow run main.nf -profile test,docker,gitpod --subworkflow 'abinitio_training' -resume  # passes
nextflow run main.nf -profile test,docker,gitpod --subworkflow 'annotation_preprocessing' -resume # passes
nextflow run main.nf -profile test,docker,gitpod --subworkflow 'functional_annotation' -resume # fails: Interproscan is still flaky
nextflow run main.nf -profile test,docker,gitpod --subworkflow 'transcript_assembly' -resume # passes

@LucileSol
Copy link
Contributor

I have not tested it yet, planning to do that next week.

@LucileSol
Copy link
Contributor

The pipeline seems to be splitting the gff file into mrna.gff and trna.gff, four times (I gave it 2 sets of parameters). It would be more efficient/faster
if it does it only once.

@LucileSol
Copy link
Contributor

LucileSol commented Sep 28, 2023

I got an error message :


Error executing process > 'ABINITIO_TRAINING:BLAST_RECURSIVE (codingGeneFeatures.filter.longest_cds.complete.good_distance_proteins)'

Caused by:
  Process `ABINITIO_TRAINING:BLAST_RECURSIVE` input file name collision -- There are multiple input files for each of the following file names: blast_db

@mahesh-panchal
Copy link
Collaborator Author

Yes, I'm debugging that now. I just updated the test profile.

@mahesh-panchal
Copy link
Collaborator Author

😮 All tests pass 🚀

@mahesh-panchal
Copy link
Collaborator Author

Going to add summary script too now. https://github.com/NBISweden/annotation-cluster/wiki/Old-Abinitio_pipeline

@mahesh-panchal mahesh-panchal marked this pull request as draft September 29, 2023 14:20
@mahesh-panchal mahesh-panchal self-assigned this Sep 29, 2023
@mahesh-panchal mahesh-panchal marked this pull request as ready for review October 3, 2023 08:36
@mahesh-panchal
Copy link
Collaborator Author

All tests pass locally.

@mahesh-panchal mahesh-panchal merged commit 8b6c7fa into NBISweden:master Oct 12, 2023
8 checks passed
@mahesh-panchal mahesh-panchal deleted the feature_aed_ld_parameter_sweep branch October 12, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update params.conda to conda.enabled Augustus training parameter tuning
2 participants