Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOI code cleanup #1248

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

AOI code cleanup #1248

wants to merge 40 commits into from

Commits on Sep 10, 2024

  1. Expose ExplorationAndAnalysis component, update date-fns for building…

    … library, and get to render in nextJs instance
    sandrahoang686 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2341e1b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    b5e5ff9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    606acc9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    ecf0989 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97112dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3aed77b View commit details
    Browse the repository at this point in the history
  4. add comment

    sandrahoang686 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c949b35 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    c85eba0 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    8ee8253 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Fix lint

    dzole0311 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d7f5070 View commit details
    Browse the repository at this point in the history
  2. Fix unmount error

    dzole0311 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8bf1abf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b2eee6d View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Clean up

    dzole0311 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f5ff42c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4ca598 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    ae793f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f7a4284 View commit details
    Browse the repository at this point in the history
  3. lint

    hanbyul-here committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ce6bd1c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    588fd8b View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Make Data selector modal work (#1213)

    **Related Ticket:** #1156 
    
    ### Description of Changes
    - The main reason the data selector modal was not working is ~ again ~
    link-related components error. I made it use `linkProperties` props.
    - I also moved `LinkProperties` type to `types/veda` 
    
    ### Notes & Questions About Changes
    I will inline-comment
    
    ### Validation / Testing
    - Build the library from this branch
    - Use the built asset with this branch (of Next instance) :
    https://github.com/developmentseed/next-veda-ui/tree/data-selector-modal-test
    hanbyul-here authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2ae4c21 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    1f52025 View commit details
    Browse the repository at this point in the history
  2. Revert fix attempt

    dzole0311 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c6aadaf View commit details
    Browse the repository at this point in the history
  3. Fix map controls and resolve Analyses Message issue (#1205)

    **Related Ticket:** #1155
    #1172
    
    Related Next.js PR:
    developmentseed/next-veda-ui#7
    
    ### Description of Changes
    
    - Fixed the map controls so that they work in the Next.js instance
    - Resolve issue with the Analyses Message display
    - Attempted to address the React mount error mentioned in
    #1172
    
    ### Notes & Questions About Changes
    _{Add additonal notes and outstanding questions here related to changes
    in this pull request}_
    
    ### Validation / Testing
    1. Verify that the AOI controls and Analyses Message work as expected in
    both veda-ui and the Next.js instance
    2. Verify that adding, deleting a single drawn area, or deleting all
    drawn areas works without issues
    3. Ensure that analyses execute as expected
    dzole0311 authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    772b19b View commit details
    Browse the repository at this point in the history
  4. Fix imports

    dzole0311 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4848c88 View commit details
    Browse the repository at this point in the history
  5. Add missing import

    dzole0311 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    195e3f3 View commit details
    Browse the repository at this point in the history
  6. [REFACTOR] Import fixes needed for the Next.js instance (#1222)

    **Related Ticket:** #1158
    
    ### Description of Changes
    The PR fixes `date-fns` imports which are breaking in Next.js, probably
    due to how Next.js handles ESM and CommonJS module imports.
    
    Next.js PR with explanation of the core issue:
    developmentseed/next-veda-ui#8
    
    ### Notes & Questions About Changes
    _{Add additonal notes and outstanding questions here related to changes
    in this pull request}_
    
    ### Validation / Testing
    _{Update with info on what can be manually validated in the Deploy
    Preview link for example "Validate style updates to selection modal do
    NOT affect cards"}_
    dzole0311 authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ef4a30c View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    7e4cf7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f69a4a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e01d03e View commit details
    Browse the repository at this point in the history
  4. Flag the problem - 1

    hanbyul-here committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4a0318f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0fc1b2b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    889bd47 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    bafb20e View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Add last array method

    hanbyul-here committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ed269c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc0408a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    f5bb96c View commit details
    Browse the repository at this point in the history
  2. Various fixes for E&A (#1229)

    **Related Ticket:** #1220
    
    ### Description of Changes
    This PR is WIP, opening in case it helps anybody. (That says, please
    don't spend time reviewing the changes in this PR yet, but it will be
    really helpful if you can validate that this branch can run with Next
    instance with stability.)
    
    ### Notes & Questions About Changes
    I've noticed E&A still doesn't run with stability in Next instance. I
    traced down all the possible errors that I can spot. That includes
    #### Fixed in this PR
    - export useAtom hook for timelinedataset (to remove the possibility of
    more than one jotai instances)
    - LinkProperties problem 
    - MapboxDraw not added to the map yet when its method is called
    - Date value that gets fed to atom is not valid - this was because our
    polyfill for Array.last was not getting exported
    
    #### Not fixed in this PR yet
    
    - TimelineDatasetAtom still depends on veda faux module datasets 
    
    I put temporary work-arounds for unsolved problems to validate that
    those are the errors that can interrupt Next instance.
    
    ### Validate & Test
    Please test this branch with `test-branch` Next branch :
    https://github.com/developmentseed/next-veda-ui/tree/test-branch - It
    will still lack of some functionalities, but hopefully the e&a page
    doesn't return abrupt errors anymore.
    sandrahoang686 authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7771378 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Remove unused files

    AliceR committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2c61865 View commit details
    Browse the repository at this point in the history
  2. Clean up effect dependencies

    AliceR committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ffff3c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ea2634c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    17361f3 View commit details
    Browse the repository at this point in the history