DLCs #888
Draft
DLCs #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
dlcs
branch
4 times, most recently
from
c1a42b1
to
15ea799
Compare
benthecarman
force-pushed
the
dlcs
branch
11 times, most recently
from
93979df
to
eb772f6
Compare
benthecarman
force-pushed
the
dlcs
branch
2 times, most recently
from
befbdc5
to
f90574c
Compare
benthecarman
force-pushed
the
dlcs
branch
4 times, most recently
from
cbe52a8
to
8091df5
Compare
benthecarman
force-pushed
the
dlcs
branch
2 times, most recently
from
a59c599
to
828783b
Compare
|
Code looks pretty clean and self contained, nice job so far. What's the status on it? |
|
needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening for now so I can better document changes I need to make
Currently can open and close DLCs with my dummy function
test_send_dlc_offer.Has some current problems
rust_dlc)Same nostr key for DLCsCannot statically receive bets without thisrust-nostrv26)Some other todos for usability
Longer term todos