Per world inventory data import #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwoo1110
added
PR: Enhancement
benwoo1110
force-pushed
the
per-world-inventory
branch
from
5b7c514
to
97490d0
Compare
|
Test Build: |
|
Got some early feedback on the current state of this pull request:
In case the line numbers don't line up, I did do a |
|
Well this is quite a bit more important now that PerWorldInventory's repository has been archived with no explanation, and it was never even updated to 1.17, which tells me that it's a dead plugin. |
|
I was able to progress more with this patch: diff --git a/src/main/java/com/onarandombox/multiverseinventories/dataimport/perworldinventory/PwiImportHelper.java b/src/main/java/com/onarandombox/multiverseinventories/dataimport/perworldinventory/PwiImportHelper.java
index fa76d5c..2c606ac 100644
--- a/src/main/java/com/onarandombox/multiverseinventories/dataimport/perworldinventory/PwiImportHelper.java
+++ b/src/main/java/com/onarandombox/multiverseinventories/dataimport/perworldinventory/PwiImportHelper.java
@@ -173,6 +173,7 @@ class PwiImportHelper {
PlayerProfile pwiPlayerProfile;
try {
JSONObject jsonObject = (JSONObject) PARSER.parse(new FileInputStream(pwiPlayerDataFile));
+ jsonObject.put("==", "me.ebonjaeger.perworldinventory.data.PlayerProfile");
pwiPlayerProfile = (PlayerProfile) SerializationHelper.deserialize(jsonObject);
} catch (Exception e) {
e.printStackTrace();Here's my build with that patch: Multiverse-Inventories-4.2.3-SNAPSHOT.zip I get this output now: |
|
This is a feature I would be very interested in, perworldinventory-kt no longer seems active :/ |
|
Is there any progress yet? I could use it too. |
i made #523 to adress your concerns, the error you posted is because you did not run "/pwi migrate" before running "/mvinv import".
All you did here was trick pwi into thinking your stuff was already migrated, this is bad. 👎🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for PerWorldInventory data import! Fixes #410. Will need #432 to be merged first.