Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for skinned Mesh #4968

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

chore: simplify skinned mesh component

6b60fbe
Select commit
Loading
Failed to load commit list.
Open

feat: add support for skinned Mesh #4968

chore: simplify skinned mesh component
6b60fbe
Select commit
Loading
Failed to load commit list.
Terasology Jenkins.io / PMD succeeded Sep 12, 2023 in 0s

4 new issues, 376 total.

Total New Outstanding Fixed Trend
376 4 372 0 👎

Reference build: Terasology » engine » develop #28

Details

Severity distribution of new issues

Error Warning High Warning Normal Warning Low
0 1 3 0

Annotations

Check warning on line 75 in engine/src/main/java/org/terasology/engine/rendering/logic/SkinnedMeshRenderer.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedPrivateField

NORMAL:
Avoid unused private fields such as 'random'.
Raw output
Detects when a private field is declared and/or assigned a value, but not used. Since PMD 6.50.0 private fields are ignored, if the fields are annotated with any annotation or the enclosing class has any annotation. Annotations often enable a framework (such as dependency injection, mocking or e.g. Lombok) which use the fields by reflection or other means. This usage can't be detected by static code analysis. Previously these frameworks where explicitly allowed by listing their annotations in the property "ignoredAnnotations", but that turned out to be prone of false positive for any not explicitly considered framework. <pre> <code> public class Something { private static int FOO = 2; // Unused private int i = 5; // Unused private int j = 6; public int addOne() { return j++; } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedprivatefield"> See PMD documentation. </a>

Check warning on line 126 in engine/src/main/java/org/terasology/engine/rendering/logic/SkinnedMeshRenderer.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedFormalParameter

NORMAL:
Avoid unused method parameters such as 'delta'.
Raw output
Reports parameters of methods and constructors that are not referenced them in the method body. Parameters whose name starts with `ignored` or `unused` are filtered out. Removing unused formal parameters from public methods could cause a ripple effect through the code base. Hence, by default, this rule only considers private methods. To include non-private methods, set the `checkAll` property to `true`. <pre> <code> public class Foo { private void bar(String howdy) { // howdy is not used } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedformalparameter"> See PMD documentation. </a>

Check warning on line 34 in engine/src/main/java/org/terasology/engine/rendering/gltf/GLTFSkinnedMeshFormat.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

UnusedPrivateField

NORMAL:
Avoid unused private fields such as 'logger'.
Raw output
Detects when a private field is declared and/or assigned a value, but not used. Since PMD 6.50.0 private fields are ignored, if the fields are annotated with any annotation or the enclosing class has any annotation. Annotations often enable a framework (such as dependency injection, mocking or e.g. Lombok) which use the fields by reflection or other means. This usage can't be detected by static code analysis. Previously these frameworks where explicitly allowed by listing their annotations in the property "ignoredAnnotations", but that turned out to be prone of false positive for any not explicitly considered framework. <pre> <code> public class Something { private static int FOO = 2; // Unused private int i = 5; // Unused private int j = 6; public int addOne() { return j++; } } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_bestpractices.html#unusedprivatefield"> See PMD documentation. </a>

Check warning on line 34 in engine/src/main/java/org/terasology/engine/rendering/gltf/GLTFSkinnedMeshFormat.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / PMD

LoggerIsNotStaticFinal

HIGH:
The Logger variable declaration does not contain the static and final modifiers.
Raw output
In most cases, the Logger reference can be declared as static and final. _Note:_ This rule is deprecated since PMD 6.15.0 and will be removed with PMD 7.0.0. The rule is replaced by {% rule java/errorprone/ProperLogger %}. <pre> <code> public class Foo{ Logger log = Logger.getLogger(Foo.class.getName()); // not recommended static final Logger log = Logger.getLogger(Foo.class.getName()); // preferred approach } </code> </pre> <a href="https://pmd.github.io/pmd-6.53.0/pmd_rules_java_errorprone.html#loggerisnotstaticfinal"> See PMD documentation. </a>