Update proof-systems: external prover randomness & regression tests #16139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
Merged
|
!ci-build-me |
|
!ci-nightly-me |
|
LGTM so far. Waiting for the PRs to be ready. |
volhovm
force-pushed
the
volhovm/arkworks024-regression-tests
branch
from
47cdfa0
to
391f009
Compare
volhovm
force-pushed
the
volhovm/arkworks024-regression-tests
branch
from
391f009
to
d68deac
Compare
|
!ci-build-me |
|
!ci-nightly-me |
dannywillems
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
LGTM. The proof systems commit is targeting the expected one, which is eb5357a69a93b90e79a75666bf61472ab2e1f625 (branch o1-labs/proof-systems#2598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o1-labs/proof-systems#2598 introduces serialization tests into
proof-systems. For that it was necessary to make kimchi prover takerngexplicitly (Instead of taking&mut rand::rngs::OsRnginternally), this is merely a semantic change.This PR propagates this semantics to
minaand updates to the new version of proof-systems.