-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade 2021 #17
Draft
DanielJoyce
wants to merge
13
commits into
master
Choose a base branch
from
upgrade-2021
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade 2021 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dependencies * Tweak readme * Fix rustfmt file * Format files
* Will use Figment for config * Bring in hyper, tungstenite * Bring in anyhow, thiserror for error handling * Bring in tokio, async-trait for new async stuff
* Fix up impact on other modules
* Bring in struct opt for cli * Bring in Figment for multiple config source control * Change name to wssps to match with the full name * TODO Create proper multi format provider for Figment and remove panic * TODO Add config tests
* Properly merge from defaults, env and cli * If file is specified, merge that too
* Nothing else is wired in yet.
* Bring in future-utils * Set up logging * Use hyperium-tungstenite to set up socket upgrade * Echo back wensocket messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for upcaming changes for 2021