Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links - JasonGerend - 1 #3900

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Broken links - JasonGerend - 1 #3900

merged 5 commits into from
Nov 25, 2024

Conversation

Albertyang0
Copy link
Contributor

@Albertyang0 Albertyang0 commented Nov 8, 2024 •
edited
Loading

Hi @JasonGerend, I've fixed the broken links. Please verify. Thanks!

See: https://dev.azure.com/msft-skilling/Content/_workitems/edit/340770

PR Summary

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@Albertyang0 Albertyang0 removed the request for review from JasonGerend November 8, 2024 22:38
@Albertyang0 Albertyang0 marked this pull request as draft November 8, 2024 22:45
@Albertyang0 Albertyang0 marked this pull request as ready for review November 8, 2024 23:15
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 28e5163:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012r2-ps/adfs/Get-AdfsRelyingPartyTrust.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Get-HpcJobCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/New-HpcSoftCard.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcNodeState.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcPool.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcSoaCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcTask.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcTestCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Shutdown-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcAzureNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcNodeSet.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcAzureNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcJob.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcNodeSet.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcTask.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcTestResult.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Submit-HpcJob.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Validate-HpcIScsiStorageArray.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/bestpractices/Invoke-BpaModel.md ✅Succeeded View (WindowsServer2016-ps)

For more details, please refer to the build report.

For any questions, please:

@Albertyang0
Copy link
Contributor Author

#sign-off

@Albertyang0
Copy link
Contributor Author

Albertyang0 commented Nov 22, 2024 •
edited
Loading

Hi @JasonGerend - There is another PR here, could you review it together? Thank you very much!

@Albertyang0 Albertyang0 mentioned this pull request Nov 22, 2024
Open
4 tasks
JasonGerend
JasonGerend requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@JasonGerend JasonGerend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions on things to change--take a look and see what you think. Thanks for helping us fix these links! :)

docset/winserver2012r2-ps/hpc/Get-HpcJobCredential.md Outdated Show resolved Hide resolved
docset/winserver2016-ps/bestpractices/Invoke-BpaModel.md Outdated Show resolved Hide resolved
docset/winserver2012r2-ps/adfs/Get-AdfsRelyingPartyTrust.md Show resolved Hide resolved
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 1a25a7b:

💡 Validation status: suggestions

File Status Preview URL Details
docset/winserver2012r2-ps/adfs/Get-AdfsRelyingPartyTrust.md 💡Suggestion View (winserver2012r2-ps) Details
docset/winserver2012r2-ps/hpc/Get-HpcJobCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/New-HpcSoftCard.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcNodeState.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcPool.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcSoaCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcTask.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcTestCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Shutdown-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcAzureNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcNodeSet.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcAzureNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcJob.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcNodeSet.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcTask.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcTestResult.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Submit-HpcJob.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Validate-HpcIScsiStorageArray.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/bestpractices/Invoke-BpaModel.md ✅Succeeded View (WindowsServer2016-ps)

docset/winserver2012r2-ps/adfs/Get-AdfsRelyingPartyTrust.md

  • Line 0, Column 0: [Suggestion: other-site-link-broken - See documentation] Link 'https://app.fabrikam.com' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 0fc1f48:

💡 Validation status: suggestions

File Status Preview URL Details
docset/winserver2012r2-ps/adfs/Get-AdfsRelyingPartyTrust.md 💡Suggestion View (winserver2012r2-ps) Details
docset/winserver2012r2-ps/hpc/Get-HpcJobCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/New-HpcSoftCard.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcNodeState.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcPool.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcSoaCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcTask.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Set-HpcTestCredential.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Shutdown-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcAzureNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Start-HpcNodeSet.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcAzureNode.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcJob.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcNodeSet.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcTask.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Stop-HpcTestResult.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Submit-HpcJob.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2012r2-ps/hpc/Validate-HpcIScsiStorageArray.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/bestpractices/Invoke-BpaModel.md ✅Succeeded View (WindowsServer2016-ps)

docset/winserver2012r2-ps/adfs/Get-AdfsRelyingPartyTrust.md

  • Line 0, Column 0: [Suggestion: other-site-link-broken - See documentation] Link 'https://app.fabrikam.com' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@JasonGerend
Copy link
Contributor

#sign-off

@JasonGerend JasonGerend merged commit aa5f1ad into MicrosoftDocs:main Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGerend JasonGerend JasonGerend approved these changes

Assignees
No one assigned
Labels
Microsoft submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Albertyang0 @JasonGerend