feat(27256): implement remote feature flag feature #28684

DDDDDanica · 2024-11-25T13:10:41Z

Description

Consume feature-flag-controller built in Create a new feature-flag-controller #27254.
And When Basic Functionality toggle is OFF, feature flag request should not be made, not call getFeatureFlags, which can be aligned with https://github.com/MetaMask/mobile-planning/issues/1975

Related issues

Fixes: #27256

Manual testing steps

Load the extension
Option 1: input chrome.storage.local.get(console.log) in dev tools console, and you'll find in data => RemoteFeatureFlagController => contains 2 dataset, cacheTimestamp and remoteFeatureFlags with value
Option 2: go to settings => advanced, and click download stage logs button, you'll find remoteFeatureFlags with cached value in your state.
Option 3: Settings => about page, if you open console in dev tools, there's a log after Feature flag fetched successfully, which will be removed after we implement 1st feature flag in production

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-25T13:10:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sentry-io · 2024-11-25T13:11:17Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/scripts/background.js

Function	Unhandled Issue
`setupController`	Error: Custom network client not found with ID '8f31c082-5580-4881-b948-616db1204095' ... `Event Count:` 230 `Affected Users:` 0
`initialize`	TypeError: e is not iterable /scripts/app-init.js `Event Count:` 147 `Affected Users:` 0
`setupController`	Error: NetworkController state is invalid: `selectedNetworkClientId` '54875d44-238f-416a-8033-765a3a2307... ... `Event Count:` 71 `Affected Users:` 0

_{Did you find this useful? React with a 👍 or 👎}

DDDDDanica · 2024-11-28T00:39:10Z

ui/pages/settings/settings.container.js

@@ -60,7 +61,7 @@ const mapStateToProps = (state, ownProps) => {
  const {
    metamask: { currencyRates },
  } = state;
-
+  const remoteFeatureFlags = getRemoteFeatureFlags(state);


Will be removed after 1st feature flag is implemented in production

DDDDDanica · 2024-11-28T00:39:17Z

ui/pages/settings/info-tab/info-tab.component.js

@@ -53,6 +57,13 @@ export default class InfoTab extends PureComponent {
  componentDidMount() {
    const { t } = this.context;
    handleSettingsRefs(t, t('about'), this.settingsRefs);
+    if (this.props.remoteFeatureFlags.length > 0) {


Will be removed after 1st feature flag is implemented in production

Instead of (this.props.remoteFeatureFlags.length > 0, can we use an actual feature flag. So that this becomes something like

if (this.props.remoteFeatureFlags[TEST_FLAG] > 0) { console.log(

So we can fully demonstrate how teams would use the feature flag system?

Good idea, added 5204e9c

danjm · 2024-11-28T17:28:24Z

app/scripts/background.js

@@ -885,12 +884,16 @@ export function setupController(
        senderUrl?.origin === `chrome-extension://${browser.runtime.id}`;
    }

+    controller.remoteFeatureFlagController.getRemoteFeatureFlags();


we will need error handling here now

and should we remove the controller.remoteFeatureFlagController.getRemoteFeatureFlags() call on 887, because we have one on 896?

Yes this line is removed, it was for testing purpose 🙏🏻

Error handling within initializeRemoteFeatureFlags can be found 5204e9c

app/scripts/background.js

socket-security · 2024-11-28T19:56:49Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

…ation

DDDDDanica · 2024-11-29T23:45:06Z

@metamaskbot update-policies

metamaskbot · 2024-11-29T23:47:01Z

Policy update failed. You can review the logs or retry the policy update here

DDDDDanica · 2024-11-30T00:39:03Z

@metamaskbot update-policies

metamaskbot · 2024-11-30T00:46:08Z

Policy update failed. You can review the logs or retry the policy update here

DDDDDanica · 2024-11-30T00:59:39Z

@metamaskbot update-policies

metamaskbot · 2024-11-30T01:01:25Z

Policy update failed. You can review the logs or retry the policy update here

This reverts commit 5a8a088.

socket-security · 2024-11-30T01:22:08Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/remote-feature-flag-controller@1.0.0	None	`0`	115 kB	metamaskbot

View full report↗︎

DDDDDanica · 2024-11-30T02:14:33Z

@metamaskbot update-policies

metamaskbot · 2024-11-30T02:24:22Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

DDDDDanica · 2024-11-30T04:07:41Z

@metamaskbot update-policies

metamaskbot · 2024-11-30T04:17:12Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot added the team-extension-platform label Nov 25, 2024

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch 13 times, most recently from 3942cd2 to 9bddc8d Compare November 27, 2024 23:55

DDDDDanica commented Nov 28, 2024

View reviewed changes

danjm reviewed Nov 28, 2024

View reviewed changes

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch from 0e78bb0 to e1c605a Compare November 28, 2024 17:43

danjm reviewed Nov 28, 2024

View reviewed changes

app/scripts/background.js Outdated Show resolved Hide resolved

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch 2 times, most recently from d6d0a91 to a2b12b6 Compare November 28, 2024 19:56

DDDDDanica self-assigned this Nov 28, 2024

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch from a2b12b6 to 79cdc1c Compare November 28, 2024 21:31

DDDDDanica marked this pull request as ready for review November 28, 2024 21:33

DDDDDanica requested review from a team as code owners November 28, 2024 21:33

DDDDDanica and others added 8 commits November 29, 2024 22:28

feat(27256): update e2e tests

6bc1abb

feat(27256): revert get remote feature flags by name

cb6aacb

Update LavaMoat policies

561de59

Update ui/pages/settings/info-tab/info-tab.component.js

5fc1777

feat(27256): add controller state to sentry state

3ad13ae

feat(27256): modify initializeRemoteFeatureFlags to async and add jsdoc

682d174

feat(27256): address types and required props

5c81f2a

feat(27256): remove unused actions and events in controller initializ…

7967c9b

…ation

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch from 3483879 to fe30412 Compare November 29, 2024 23:38

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch from fe30412 to 8a0160f Compare November 30, 2024 00:05

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch from 8a0160f to b2940dd Compare November 30, 2024 00:50

Update LavaMoat policies

5a8a088

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch from b2940dd to 5a8a088 Compare November 30, 2024 01:08

Revert "Update LavaMoat policies"

46903fb

This reverts commit 5a8a088.

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch from 948446f to a3f90aa Compare November 30, 2024 02:09

feat(27256): refactor types for _getConfigForRemoteFeatureFlagRequest

a26c834

DDDDDanica force-pushed the feature/27256-remote-feature-flag branch from d30565a to a26c834 Compare November 30, 2024 03:01

Update LavaMoat policies

f2b791b

danjm approved these changes Dec 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(27256): implement remote feature flag feature #28684

feat(27256): implement remote feature flag feature #28684

DDDDDanica commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024

sentry-io bot commented Nov 25, 2024

DDDDDanica Nov 28, 2024

DDDDDanica Nov 28, 2024

danjm Nov 28, 2024

DDDDDanica Nov 28, 2024

danjm Nov 28, 2024

danjm Nov 28, 2024

DDDDDanica Nov 28, 2024

DDDDDanica Nov 28, 2024

socket-security bot commented Nov 28, 2024 •

edited

Loading

DDDDDanica commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

DDDDDanica commented Nov 30, 2024

metamaskbot commented Nov 30, 2024

DDDDDanica commented Nov 30, 2024

metamaskbot commented Nov 30, 2024

socket-security bot commented Nov 30, 2024 •

edited

Loading

DDDDDanica commented Nov 30, 2024

metamaskbot commented Nov 30, 2024

DDDDDanica commented Nov 30, 2024

metamaskbot commented Nov 30, 2024

feat(27256): implement remote feature flag feature #28684

Are you sure you want to change the base?

feat(27256): implement remote feature flag feature #28684

Conversation

DDDDDanica commented Nov 25, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 25, 2024

sentry-io bot commented Nov 25, 2024

🔍 Existing Issues For Review

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

socket-security bot commented Nov 28, 2024 • edited Loading

DDDDDanica commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

DDDDDanica commented Nov 30, 2024

metamaskbot commented Nov 30, 2024

DDDDDanica commented Nov 30, 2024

metamaskbot commented Nov 30, 2024

socket-security bot commented Nov 30, 2024 • edited Loading

DDDDDanica commented Nov 30, 2024

metamaskbot commented Nov 30, 2024

DDDDDanica commented Nov 30, 2024

metamaskbot commented Nov 30, 2024

DDDDDanica commented Nov 25, 2024 •

edited

Loading

socket-security bot commented Nov 28, 2024 •

edited

Loading

socket-security bot commented Nov 30, 2024 •

edited

Loading