Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bridge QA branch #28373

Draft
wants to merge 140 commits into
base: main
Choose a base branch
from
Draft

chore: bridge QA branch #28373

wants to merge 140 commits into from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Nov 8, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae force-pushed the mb891-sort-bridge-quotes branch 2 times, most recently from fd6acbb to 01d4837 Compare November 9, 2024 00:53
@micaelae micaelae force-pushed the mb894-style-quotes-1 branch 2 times, most recently from 1f2a2d4 to 38aaead Compare November 11, 2024 23:43
@micaelae micaelae force-pushed the mb891-sort-bridge-quotes branch 7 times, most recently from 867026c to a408f61 Compare November 14, 2024 23:20
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Nov 15, 2024

Copy link

socket-security bot commented Nov 15, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/@metamask/signature-controller@21.1.0 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/signature-controller@21.1.0

@micaelae micaelae changed the title chore: bridge page layout update chore: bridge QA branch Nov 15, 2024
@micaelae micaelae force-pushed the mb891-sort-bridge-quotes branch 8 times, most recently from c699177 to 38bf939 Compare November 20, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants