Skip to content

Commit

Permalink
feat(extensions): scenegraph: if not support material type, warn inst…
Browse files Browse the repository at this point in the history
…ead of throw
  • Loading branch information
yyc-git committed Oct 20, 2023
1 parent d860630 commit b2cda84
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 2 deletions.
20 changes: 20 additions & 0 deletions doc/0.19.0.org
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,23 @@ TODO support drag loaded file to scene view



** TODO ui: Window

TODO layout: second line
first line: 2 button with image: remove, load
second line: icons:image+name

TODO drag icon to scene

TODO scroll bar




TODO use glb image instead of wdb image


** TODO support remove glb



Expand Down Expand Up @@ -71,6 +87,10 @@ e.g. show import progress bar
publish, export should show Modal



* TODO fix: solve click button blink problem


/*

* TODO Debug Output
Expand Down
6 changes: 4 additions & 2 deletions utils/meta3d-scenegraph-converter-three-utils/src/Main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1574,11 +1574,13 @@ let _getBufferGeometry = (mesh: MeshType): BufferGeometryType => {
let _getMeshStandardMaterial = (mesh: MeshType): MeshStandardMaterialType => {
let material = mesh.material as MeshStandardMaterialType

if (material.type == "MeshStandardMaterial" || material.type == "MeshPhysicalMaterial") {
if (material.type == "MeshStandardMaterial") {
return material
}

throw new Error("error")
console.warn(`unsupport material type: ${material.type}`);

return material
}

let _convertWrapToScene = (wrap_: Wrapping) => {
Expand Down

0 comments on commit b2cda84

Please sign in to comment.