Update pvalue_maxcombo() and move dplyr to Suggests #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #111, I updated
pvalue_maxcombo()
, which allowed me to move dplyr from Imports to SuggestsHowever, something to discuss, is I also updated the function signature. I found the mysterious
dummy_var
input variable to be confusing. It is only used when called bygroup_map()
, and even then it's not obvious from the code how this is happening. Looking at the examples in?group_map
, they all use the syntaxgroup_map(~ name_of_function(.x))
, so I updated all the instances ofgroup_map()
to use this syntax. Ifdummy_var
is preferred, I can revert this change.From a speed perspective, the mean was mostly unchanged, but the median runtime was reduced almost 4x: