Convert sim_fixed_n() to use data.table internally #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the migration to use data.table as the table backend (#111). I started by converting the function
sim_fixed_n()
(and all its downstream functions). This resulted in a ~5x speedup (#111 (comment))While working on the data.table conversion, I also made a few other changes:
workflow_dispatch
to theR CMD check
workflow, which allows you to manually trigger a pipeline from any branch. The workflow is setup to only run on the "main" branch, and I like to be able to test the changes I make on a feature branch before opening a PRSIMTRIAL_TEST_BACKWARDS_COMPATIBILITY_REF
is defined, the tests will install that previous version of simtrial, generates results, and then tests that the current version is compatible. This avoids bloating the Git repo and the R package with many.rds
files