Do not provide default method for S3 generic wlr()

Merck · Aug 20, 2024 · 875d1f6 · 875d1f6
1 parent b3e480d
commit 875d1f6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 12 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -1,7 +1,6 @@
 # Generated by roxygen2: do not edit by hand
 
 S3method(wlr,counting_process)
-S3method(wlr,default)
 S3method(wlr,tte_data)
 export(counting_process)
 export(create_cut)

diff --git a/R/wlr.R b/R/wlr.R
@@ -98,21 +98,16 @@ wlr <- function(data, weight, return_variance = FALSE) {
   UseMethod("wlr", data)
 }
 
-#' @rdname wlr
-#' @export
-wlr.counting_process <- function(data, weight, return_variance = FALSE) {
-  wlr.default(data, weight, return_variance = FALSE)
-}
-
 #' @rdname wlr
 #' @export
 wlr.tte_data <- function(data, weight, return_variance = FALSE) {
   x <- data |> counting_process(arm = "experimental")
-  wlr.default(x, weight, return_variance = FALSE)
+  wlr.counting_process(x, weight, return_variance = FALSE)
 }
 
+#' @rdname wlr
 #' @export
-wlr.default <- function(data, weight, return_variance = FALSE) {
+wlr.counting_process <- function(data, weight, return_variance = FALSE) {
   x <- data
 
   # calculate the sample size and randomization ratio

diff --git a/man/wlr.Rd b/man/wlr.Rd
diff --git a/tests/testthat/test-unvalidated-wlr.R b/tests/testthat/test-unvalidated-wlr.R
@@ -21,3 +21,8 @@ test_that("wlr() accepts tte_data and counting_process objects as input", {
 
   expect_equal(results_tte_data, results_counting_process)
 })
+
+test_that("wlr() rejects input object without proper class", {
+  x <- mtcars
+  expect_error(wlr(x), "no applicable method")
+})