feat(api): writer & reader API #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iGxnon <igxnon@gmail.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
iGxnon
commented
Jul 28, 2024
benches/bulk.rs
Outdated
There was a problem hiding this comment.
Bulk benchmark should be added back 😿
README.md
Outdated
| @@ -194,13 +194,11 @@ where | |||
| } | |||
| } | |||
|
|
|||
| impl<F> Sink<Frame> for OutgoingGuard<F> | |||
| impl<F> Writer<Frame> for OutgoingGuard<F> | |||
There was a problem hiding this comment.
Implement default methods in Writer for it.
Comment on lines
+38
to
+78
| // Send data to the destination | ||
| async fn send(dst: Pin<&mut impl Writer<Message>>, data: impl Iterator<Item = u8>) { | ||
| send_with_full(dst, data, Reliability::ReliableOrdered, 0).await; | ||
| } | ||
|
|
||
| async fn send_with_reliability( | ||
| dst: Pin<&mut impl Writer<Message>>, | ||
| data: impl Iterator<Item = u8>, | ||
| reliability: Reliability, | ||
| ) { | ||
| send_with_full(dst, data, reliability, 0).await; | ||
| } | ||
|
|
||
| async fn send_with_order( | ||
| dst: Pin<&mut impl Writer<Message>>, | ||
| data: impl Iterator<Item = u8>, | ||
| order: u8, | ||
| ) { | ||
| send_with_full(dst, data, Reliability::ReliableOrdered, order).await; | ||
| } | ||
|
|
||
| async fn send_with_full( | ||
| mut dst: Pin<&mut impl Writer<Message>>, | ||
| data: impl Iterator<Item = u8>, | ||
| reliability: Reliability, | ||
| order: u8, | ||
| ) { | ||
| poll_fn(|cx| dst.as_mut().poll_ready(cx)).await.unwrap(); | ||
| dst.as_mut() | ||
| .feed(Message::new(reliability, order, Bytes::from_iter(data))); | ||
| poll_fn(|cx| dst.as_mut().poll_flush(cx)).await.unwrap(); | ||
| } | ||
|
|
||
| async fn flush(mut dst: Pin<&mut impl Writer<Message>>) { | ||
| poll_fn(|cx| dst.as_mut().poll_flush(cx)).await.unwrap(); | ||
| } | ||
|
|
||
| async fn close(mut dst: Pin<&mut impl Writer<Message>>) { | ||
| poll_fn(|cx| dst.as_mut().poll_close(cx)).await.unwrap(); | ||
| } | ||
|
|
iGxnon
commented
Jul 28, 2024
Comment on lines
+102
to
106
| /// Ping extension for client, experimental | ||
| pub trait Ping { | ||
| fn ping(self: Pin<&mut Self>) -> impl Future<Output = Result<(), Error>> + Send; | ||
| } | ||
|
|
There was a problem hiding this comment.
Provide Ping support for the client.
There was a problem hiding this comment.
For example, using WriterWrapper.
|
Closed cz we have implemented the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed the default API to use a more granular Writer API instead of the original Sink.
Signed-off-by: iGxnon igxnon@gmail.com