feat: improve generate hitresults #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxOhn
force-pushed
the
improve-hitresults
branch
from
99e40e0
to
10162f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Albeit extremely performant, osu-tools' hitresult generation does not always generate the most accurate result w.r.t. to given accuracy.
This PR re-implements hitresult generation by utilizing an optimized brute-force to get a result that matches the accuracy as close as possible. This comes to the detriment of performance.
It also adds the method
{Mode}PP::generate_stateto provide the score state that will be used in performance calculation.