fix: prevent underflow on fails due to sliders

MaxOhn · May 5, 2023 · 0c0ad34 · 0c0ad34
1 parent bd9623d
commit 0c0ad34
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@
 - __Adjustments:__
   - Specified clock rates can go below 0.001 again
 
+- __Fixes:__
+  - Fixed underflow for osu!std scores that were FCs but quit mid-slider
+
 # v0.9.4 (2023-02-09)
 
 - __Additions:__

diff --git a/src/osu/pp.rs b/src/osu/pp.rs
@@ -500,7 +500,8 @@ impl OsuPpInner {
         if self.attrs.n_sliders > 0 {
             let estimate_slider_ends_dropped =
                 ((self.state.n100 + self.state.n50 + self.state.n_misses)
-                    .min(self.attrs.max_combo - self.state.max_combo) as f64)
+                    .min(self.attrs.max_combo.saturating_sub(self.state.max_combo))
+                    as f64)
                     .clamp(0.0, estimate_diff_sliders);
             let slider_nerf_factor = (1.0 - self.attrs.slider_factor)
                 * (1.0 - estimate_slider_ends_dropped / estimate_diff_sliders).powi(3)