feat(sandside): #198 limit the number of generated passwords

Marthym · Jan 14, 2024 · a79c72d · a79c72d
1 parent c3035da
commit a79c72d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/sandside/src/main/java/fr/ght1pc9kc/baywatch/common/api/model/Entity.java b/sandside/src/main/java/fr/ght1pc9kc/baywatch/common/api/model/Entity.java
@@ -12,7 +12,7 @@
  * @param self The Persisted Entity
  * @param <T>  The type of the persisted object
  */
-@Builder(toBuilder = true)
+@Builder
 public record Entity<T>(
         @NonNull String id,
         @NonNull String createdBy,

diff --git a/sandside/src/main/java/fr/ght1pc9kc/baywatch/security/domain/PasswordServiceImpl.java b/sandside/src/main/java/fr/ght1pc9kc/baywatch/security/domain/PasswordServiceImpl.java
@@ -39,10 +39,13 @@ public Mono<PasswordEvaluation> checkPasswordStrength(User user) {
 
     @Override
     public Flux<String> generateSecurePassword(int number) {
+        if (number > 100 || number < 1) {
+            return Flux.error(() -> new IllegalArgumentException("Invalid number of passwords required !"));
+        }
         return Flux.<String>create(sink ->
                         sink.onRequest(n -> LongStream.range(0, number)
                                 .mapToObj(ignore -> passwordChecker.generate())
                                 .forEach(sink::next)))
-                .take(Integer.valueOf(number).longValue());
+                .take(number);
     }
 }