Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudbuild schedule #184

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

muschellij2
Copy link
Contributor

@muschellij2 muschellij2 commented Mar 1, 2022

The goals of this PR are:

  1. to not fail if email is not set and you're using pubsubTarget.
  2. Allow you to construct pubsub_target from create_pubsub_target if not passed in.
  3. Check if a trigger exists and create it if not.
  4. Checks to see if a topic exists before trying to create, which was causing silent bugs as the tryCatch would fail, not because it could not create the topic, but that it already existed.
  5. Allow for a different message to be passed to a pubsub target in this cr_schedule_build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant