Fix core syntax, enhance extension scope #754
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation is to simplify the coding process for core users, by providing exactly what core api offer to user.
I don't think Sumneko would directly support Core syntax/API, so I did copy and comment non available part.
Fixes #(issue)
Type of change
Any time the user change the lua builtins settings it is persisted but the user could also switch to core builtins settings with the command.
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have made changes that conform to the documentation
Todo
Lua globals are still referenced as globals across different scripts. I don't know how to fix the split of _G/_ENV.
Globals in core should be only relative to _ENV.