Fix provisioning dialog 'src_vm_id' method #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'allowed_templates' method is a core method to generate a list of templates for the selection dialog. This is explicitly necessary when creating a catalog item since the user selects the template after entering into the request dialog (in contrast to the 'Lifecycle > Provision VMs using this Template' which auto-selects the template). Without this, the following exception is raised when attempting to definite a Power HMC VM provision catalog item: FATAL -- : Error caught: [NoMethodError] undefined method `any?' for nil:NilClass
|
Checked commit jaywcarman@41cbe2b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Yeah we've been bitten by these content dialog files before, I'm not sure how best to test them since they are processed by the UI controllers |
Would love to add this, but wasn't sure how to write specs for the dialog itself. We currently have specs for the HMC |
|
I'm going to merge this anyway, since we'll have to come up with a way to do specs more comprehensively. |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Sep 27, 2023
…rc_vm_id_method Fix provisioning dialog 'src_vm_id' method (cherry picked from commit 8713488)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'allowed_templates' method is a core method to generate a list of
templates for the selection dialog. This is explicitly necessary when
creating a catalog item since the user selects the template after
entering into the request dialog (in contrast to the 'Lifecycle >
Provision VMs using this Template' which auto-selects the template).
Without this, the following exception is raised when attempting to
definite a Power HMC VM provision catalog item:
FATAL -- : Error caught: [NoMethodError] undefined method `any?' for nil:NilClass