Rename remove Record to deleteRecord

MammothPHP · Oct 14, 2024 · be44997 · be44997
1 parent d829768
commit be44997
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 14 deletions.
diff --git a/src/DataDrivers/PdoSql/PdoSql.php b/src/DataDrivers/PdoSql/PdoSql.php
@@ -20,7 +20,7 @@ class PdoSql implements WritableDriver
 
     protected readonly PDOStatement $STMT_keyExist;
     protected readonly PDOStatement $STMT_getRecordKey;
-    protected readonly PDOStatement $STMT_remove;
+    protected readonly PDOStatement $STMT_delete;
 
     public function __construct(
         public readonly PDO $db,
@@ -54,7 +54,7 @@ public function __construct(
             ';'
         );
 
-        $this->STMT_remove = $this->db->prepare(
+        $this->STMT_delete = $this->db->prepare(
             'DELETE FROM ' . $this->escapeTableName() . ' ' .
             'WHERE ' . $this->escapePrimaryKeyColumnName() . ' = ? ' .
             ';'
@@ -161,10 +161,10 @@ public function setRecordColumn(int $recordKey, int|string $columnKey, mixed $co
         throw new FeatureNotImplementedYet;
     }
 
-    public function removeRecord(int $recordKey): void
+    public function deleteRecord(int $recordKey): void
     {
-        $this->STMT_remove->bindValue(1, $recordKey, PDO::PARAM_INT);
-        $this->STMT_remove->execute();
+        $this->STMT_delete->bindValue(1, $recordKey, PDO::PARAM_INT);
+        $this->STMT_delete->execute();
     }
 
     public function keyExist(int $recordKey): bool

diff --git a/src/DataDrivers/PhpArray/PhpArrayDriver.php b/src/DataDrivers/PhpArray/PhpArrayDriver.php
@@ -59,7 +59,7 @@ public function addRecord(array $recordData): void
         $this->data[] = $recordData;
     }
 
-    public function removeRecord(int $recordKey): void
+    public function deleteRecord(int $recordKey): void
     {
         $this->mustHaveValidRecordKey($recordKey);
 

diff --git a/src/DataDrivers/WritableDriver.php b/src/DataDrivers/WritableDriver.php
@@ -12,5 +12,5 @@ public function setRecordColumn(int $recordKey, int|string $columnKey, mixed $co
 
     public function addRecord(array $recordData): void;
 
-    public function removeRecord(int $recordKey): void;
+    public function deleteRecord(int $recordKey): void;
 }
diff --git a/src/DataFrameAccessors.php b/src/DataFrameAccessors.php
@@ -64,7 +64,7 @@ public function offsetSet(mixed $index, mixed $row): void
      */
     public function offsetUnset(mixed $offset): void
     {
-        $this->removeRecord($offset);
+        $this->deleteRecord($offset);
     }
 
     /* *****************************************************************************************************************

diff --git a/src/DataFramePrimitives.php b/src/DataFramePrimitives.php
@@ -287,11 +287,11 @@ public function updateCell(int $recordKey, string $column, mixed $newValue): sta
      * Remove a record by key
      * @throws KeyNotExistException
      */
-    public function removeRecord(int $key): static
+    public function deleteRecord(int $key): static
     {
         $this->mustBeWritableDriver();
 
-        $this->data->removeRecord($key);
+        $this->data->deleteRecord($key);
 
         return $this;
     }

diff --git a/src/Statements/Delete/Delete.php b/src/Statements/Delete/Delete.php
@@ -27,7 +27,7 @@ public function execute(): DataFrame
      */
     public function record(int $key): DataFrame
     {
-        return $this->getLinkedDataFrame()->removeRecord($key);
+        return $this->getLinkedDataFrame()->deleteRecord($key);
     }
 
     /**
@@ -40,7 +40,7 @@ public function filter(Closure $f): DataFrame
 
         foreach ($this as $recordKey => $recordData) {
             if ($f($recordData, $recordKey) === true) {
-                $df->removeRecord($recordKey);
+                $df->deleteRecord($recordKey);
             }
         }
 

diff --git a/tests/Unit/DataDrivers/DataDriversUnitTest.php b/tests/Unit/DataDrivers/DataDriversUnitTest.php
@@ -46,7 +46,7 @@ public function getIterator(): ArrayIterator
         ->toThrow(DriverIsNotWritableException::class);
     expect(fn() => $df->updateRecord(0, []))
         ->toThrow(DriverIsNotWritableException::class);
-    expect(fn() => $df->removeRecord(0))
+    expect(fn() => $df->deleteRecord(0))
         ->toThrow(DriverIsNotWritableException::class);
     expect(fn() => $df->insert())
         ->toThrow(DriverIsNotWritableException::class);

diff --git a/tests/Unit/DataDrivers/PdoSQL/PdoSqlTest.php b/tests/Unit/DataDrivers/PdoSQL/PdoSqlTest.php
@@ -31,7 +31,7 @@
 
     expect($this->df->getRecordAsArray(2))->toBe(['a' => '4', 'b' => null, 'c' => '6']);
 
-    $this->df->removeRecord(2);
+    $this->df->deleteRecord(2);
 
     expect($this->df->getRecordAsArray(2))->toBe(['a' => '4', 'b' => null, 'c' => '6']);
 })->throws(KeyNotExistException::class);