-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new map "GridWar" by mpixel #337
base: master
Are you sure you want to change the base?
Conversation
From the screenshot, sounds like a cool map :) Edit: This is my review: The map is cool, interesting, yet very simple. I like it. I don't see much of a thing which needs to be changed before a merge. Though I didn't exactly count the number of ores for each side. I think this map is suitable for all game modes we currently have(nade, classes and classic). I think in future, this map could be a good candidate for flagwars as well. There are some stuff which I don't have explicit opinion on them but are of great note:
|
Thank you for your review. Players can find some mese (15%) and iron(20%) ores from treasures. To use mese in treasures players need to have steel pickaxe at least. Also there are (2+6)*3=24 mese ores and 18+17*2=52 iron ores for each team, if I counted correctly. |
Is it like the Sierpinski triangle? I'll test it on Wednesday if I have time. |
No, it is not Sierpinski triangle, it is just 3d grid. |
What is status of this PR? |
@@ -0,0 +1,21 @@ | |||
game_modes = return {"classes","nade_fight","classic"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
game_modes = return {"classes","nade_fight","classic"} | |
game_modes = return {"classes","classic"} |
When I tested the map, it was bright enough like in the first screenshot. The walls and floor should be darker, because that was the design. |
This error happened on every map on my PC, so I ignored it. The map appears darker on your PC than on mine. This is due to the light curve gamma.
How to do this? I may add more sources of light if others also experience darkness. And gameplay in nade fights: https://youtu.be/RA1ZR9bPwog |
The map does not have any bugs in it as far as I can tell, but in my personal opinion it is a little too simple. I personally like complicated maps, so it's probably just me. Also, I also would think that more light would be nice. |
@mpixelate since it's marked as a draft, I will label it as WIP. let me know when it's ready for review again. |
Features:
Details: