Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the current mult-threading #199

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Conversation

Habush
Copy link
Contributor

@Habush Habush commented Apr 25, 2020

This fixes #198 and as @linas noted in #161 par-map introduces its own set of problems including #198 , which I suspect it has to do with the lack of locks in make-atom-set function (but I am only running two threads and one thread doesn't access the atom cache!). Hence getting rid of par-map and replacing it with other threading libraries (like on suggested in #197) maybe a good approach.

@Habush Habush requested review from tanksha and linas April 25, 2020 11:10
Copy link
Contributor

@linas linas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@linas
Copy link
Contributor

linas commented Apr 25, 2020

I don't know what's wrong with par-map I noticed that it misbehaves with the atomspace, many years ago. There's no data corruption, so it "works" -- its just the 2 threads only work 1.5x faster, and 3 threads are the same speed as one thread, and and four threads are slower than one thread. I have not been able to track down what it is, and I think that it's something deep inside of guile itself, and not something in the atomspace.

@tanksha tanksha merged commit 3332a17 into MOZI-AI:master Apr 27, 2020
@linas
Copy link
Contributor

linas commented Apr 27, 2020

FYI @Habush I thought a bit more about the par-map problem, and the only thing I could think of was that removing most mutexes from the atomspace could help. To that end, I propose opencog/atomspace#2553 as the way to do this. I don't have time to do this myself, but maybe you could get this placed onto someone else's priority list, and they could get it done? I would consult and hold-hands for the task. Its not an easy task, but its also not a hard one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doing the same biogrid annotation more than once for a gene returns empty result
3 participants