Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Detrend optimally combined data before running PCA #1090

Closed
wants to merge 3 commits into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 27, 2024

Related to #1054.

Changes proposed in this pull request:

  • Instead of just z-scoring the optimally combined data before running PCA, detrend it as well.

tedana/decomposition/pca.py Outdated Show resolved Hide resolved
tedana/decomposition/pca.py Outdated Show resolved Hide resolved
@tsalo
Copy link
Member Author

tsalo commented Apr 27, 2024

  • The three-echo PCA changes from 69 to 68 components, and the ICA (which converged before on the first seed) fails to converge in time for CircleCI.
  • The four-echo test looks exactly the same, but that could be because it has GSR enabled.
  • The five-echo PCA changes from 52 to 54 components, and the ICA (which converged before on the first seed) fails to converge in time for CircleCI.
  • Logan's 8-echo checkerboard run (with aic+minimal) runs really well.
    • BTW running it with tedana_orig results in the clearly checkerboard-related component being rejected, which makes no sense to me. That said, that's true for detrending and no-detrending versions of the workflow.

@tsalo tsalo changed the title Detrend optimally combined data before running PCA DNM: Detrend optimally combined data before running PCA Aug 5, 2024
@tsalo tsalo closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant