[fmt] setup.py and visualization

[RMeli]

Changes made in this Pull Request:

• Automatic formatting of setup.py
• Automatic formatting of visualisation/

Developers certificate of origin

• I certify that this contribution is covered by the LGPLv2.1+ license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

---

📚 Documentation preview 📚: https://mdanalysis--4726.org.readthedocs.build/en/4726/

[pep8speaks]

Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file package/MDAnalysis/visualization/streamlines.py:

Line 122:80: E501 line too long (118 > 79 characters)
Line 124:80: E501 line too long (118 > 79 characters)
Line 128:80: E501 line too long (89 > 79 characters)
Line 131:80: E501 line too long (89 > 79 characters)
Line 152:80: E501 line too long (88 > 79 characters)
Line 164:80: E501 line too long (116 > 79 characters)
Line 219:80: E501 line too long (81 > 79 characters)
Line 240:80: E501 line too long (104 > 79 characters)
Line 246:80: E501 line too long (107 > 79 characters)
Line 254:80: E501 line too long (89 > 79 characters)
Line 259:80: E501 line too long (98 > 79 characters)
Line 277:80: E501 line too long (118 > 79 characters)
Line 285:80: E501 line too long (112 > 79 characters)
Line 403:80: E501 line too long (114 > 79 characters)
Line 442:80: E501 line too long (103 > 79 characters)
Line 450:80: E501 line too long (117 > 79 characters)
Line 463:80: E501 line too long (116 > 79 characters)

• In the file package/MDAnalysis/visualization/streamlines_3D.py:

Line 158:80: E501 line too long (80 > 79 characters)
Line 165:80: E501 line too long (85 > 79 characters)
Line 195:80: E501 line too long (112 > 79 characters)
Line 197:80: E501 line too long (81 > 79 characters)
Line 218:34: E203 whitespace before ':'
Line 221:34: E203 whitespace before ':'
Line 225:35: E203 whitespace before ':'
Line 232:35: E203 whitespace before ':'
Line 267:80: E501 line too long (117 > 79 characters)
Line 272:80: E501 line too long (117 > 79 characters)
Line 274:80: E501 line too long (118 > 79 characters)
Line 316:80: E501 line too long (115 > 79 characters)
Line 366:80: E501 line too long (91 > 79 characters)
Line 423:80: E501 line too long (113 > 79 characters)
Line 603:80: E501 line too long (113 > 79 characters)
Line 606:80: E501 line too long (118 > 79 characters)
Line 611:80: E501 line too long (112 > 79 characters)
Line 615:80: E501 line too long (114 > 79 characters)
Line 642:80: E501 line too long (113 > 79 characters)
Line 644:80: E501 line too long (101 > 79 characters)
Line 645:80: E501 line too long (109 > 79 characters)
Line 652:80: E501 line too long (83 > 79 characters)

• In the file package/setup.py:

Line 183:80: E501 line too long (80 > 79 characters)
Line 470:80: E501 line too long (82 > 79 characters)
Line 472:80: E501 line too long (85 > 79 characters)
Line 624:26: E203 whitespace before ':'

Comment last updated at 2024-10-15 19:56:20 UTC

[RMeli]

Depends on https://github.com/MDAnalysis/mdanalysis/pulls and needs to be added to .git-blame-ignore-revs

[codecov]

Codecov Report

Attention: Patch coverage is 52.33645% with 51 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (48e9e01) to head (a76b31a).

Files with missing lines	Patch %	Lines
package/MDAnalysis/visualization/streamlines_3D.py	51.42%	33 Missing and 1 partial ⚠️
package/MDAnalysis/visualization/streamlines.py	52.77%	16 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4726      +/-   ##
===========================================
- Coverage    93.60%   93.58%   -0.03%     
===========================================
  Files          173      185      +12     
  Lines        21464    22530    +1066     
  Branches      2993     2993              
===========================================
+ Hits         20091    21084     +993     
- Misses         929     1002      +73     
  Partials       444      444              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marinegor]

Looks good, sorry for the slow review!🐌

[marinegor]

Depends on https://github.com/MDAnalysis/mdanalysis/pulls and needs to be added to .git-blame-ignore-revs

I didn't quite get this part

[orbeckst]

LGTM.

But please wait with merging until after 2.8.0 release.

I asssume you'll also create/update .git-blame-ignore-revs ?

[RMeli]

I asssume you'll also create/update .git-blame-ignore-revs ?

Yes. As discussed in #4725 (comment), I am tagging formatting PRs with [fmt] and they will be squash-merged. They will be added to .git-blame-ignore-revs once they are squash-merged (maybe pooling a few together).

[RMeli]

Temporarily converted to draft to prevent an accidental merge before the release.