Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the yarn mode #12

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Add the yarn mode #12

merged 3 commits into from
Aug 21, 2023

Conversation

ChappIO
Copy link
Contributor

@ChappIO ChappIO commented Aug 20, 2023

Note: I had to change NPM_BADGE_URL in the site to test this locally. Any particular reason for not using window.location to determine this value?

@LucaScorpion
Copy link
Owner

Nice addition, thanks! Just some console.log debug statements which can be removed, but other than that it seems nice.

As for the NPM_BADGE_URL variable, that's a good point. iirc the main reason I set it up like this is that I haven't set up a proxy in the frontend, so I can't just call /npm/.... But this is definitely not the best, I'll see if I can set up something nicer for that in future.

@ChappIO
Copy link
Contributor Author

ChappIO commented Aug 21, 2023

@LucaScorpion No proxy?

It worked fine for me. Eleventy builds into _site and express serves _site on port 3000. So http://localhost:3000 has both site and /npm

Also: Fixed the linting issues.

@LucaScorpion
Copy link
Owner

Uhh hm, you're right, I must have been thinking about another setup 😅 Sounds like it should be straightforward enough then, will look at that soon! For now, I'll merge this 🚀

@LucaScorpion LucaScorpion merged commit 1731c3e into LucaScorpion:main Aug 21, 2023
1 check passed
@ChappIO ChappIO deleted the add-yarn branch August 22, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants