Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for Loop 3.4.4 to restore TestFlight expiration date #2242

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

marionbarker
Copy link
Contributor

Purpose of PR

The modification previously merged and included in Loop 3.4.2 and Loop 3.4.3 fixed Xcode 16 lack of expiration date but unfortunately removed the expiration date from builds created with GitHub build action.

This PR:

  • fixes the expiration date for GitHub build actions and for Mac-Xcode builds
  • bumps up the version number to 3.4.4

See Loop PR 2241: Adjust provisioning profile path in script for Xcode 16 compatibility for more information.

Testing

Test - confirm error with Loop 3.4.3

  • Install a TestFlight build of 3.4.3 onto a test phone
    • Observe the expiration is not reported

Test - confirm PR 2241 restores TestFlight expiration

Test this by applying a customization that applies the updated code into the build_loop.yml file of a new branch in loopdocs-tester GitHub account.

curl https://github.com/loopandlearn/Loop/commit/ae76f90955843df0e1e4297f6c7c669d21e5eae2.patch | git apply --directory=Loop

Build using this customization and install onto test phone

  • Install the TestFlight build of 3.4.3 plus PR2241 onto a test phone
    • Observe the expiration is reported

Test - expiration reported with Xcode 16

Success - expiration is reported with Mac-Xcode 16 build.

Test - expiration reported with Xcode 15.4

Success - expiration is reported with Mac-Xcode 15.4 build

@ps2 ps2 merged commit 20c313c into LoopKit:main Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants