refactor: make getInstance more intuitive

LiteLDev · Mar 29, 2024 · d34cd47 · d34cd47
1 parent a6ec7ef
commit d34cd47
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/plugin/MyPlugin.cpp b/src/plugin/MyPlugin.cpp
@@ -7,9 +7,10 @@
 
 namespace my_plugin {
 
-std::unique_ptr<MyPlugin>& MyPlugin::getInstance() {
-    static std::unique_ptr<MyPlugin> instance;
-    return instance;
+static std::unique_ptr<MyPlugin> instance;
+
+MyPlugin& MyPlugin::getInstance() {
+    return *instance;
 }
 
 bool MyPlugin::load() {
@@ -32,4 +33,4 @@ bool MyPlugin::disable() {
 
 } // namespace my_plugin
 
-LL_REGISTER_PLUGIN(my_plugin::MyPlugin, my_plugin::MyPlugin::getInstance());
+LL_REGISTER_PLUGIN(my_plugin::MyPlugin, my_plugin::instance);
diff --git a/src/plugin/MyPlugin.h b/src/plugin/MyPlugin.h
@@ -7,7 +7,7 @@ namespace my_plugin {
 class MyPlugin {
 
 public:
-    static std::unique_ptr<MyPlugin>& getInstance();
+    static MyPlugin& getInstance();
 
     MyPlugin(ll::plugin::NativePlugin& self) : mSelf(self) {}