Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes #617

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Doc fixes #617

merged 2 commits into from
Oct 10, 2024

Conversation

CommonClimate
Copy link
Collaborator

These fix some mistakes/inconsistencies in Series.correlation() and MultipleSeries.correlation(). In the process, I discovered that the statistic argument had not been enabled in MultipleSeries.correlation(), so I fixed that and included a unit test for this and for the significance method. Since its uses Series.correlation() under the hood, I did not feel it was necessary to test everything under the Sun, since that is already done for in the Series.correlation() unit tests.
Also fixed a docstring error for EnsembleSeries.plot_traces() (argument change)

also, replaced plot_legend keyword in EnsemlbleSeries.plot_traces() doc
@alexkjames alexkjames merged commit a384df9 into master Oct 10, 2024
1 check passed
@alexkjames alexkjames deleted the doc_fixes branch October 10, 2024 23:27
@CommonClimate CommonClimate restored the doc_fixes branch October 18, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants