Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Docs: minimize errors related to docker volumes mounted as directories #90

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

wesfloyd
Copy link
Collaborator

@wesfloyd wesfloyd commented Apr 2, 2024

  1. Modifying the docker-compose file to avoid the frequent support issue of container files being mounted as "directories" b/c the host file didn't exist, which occurred b/c the .env directory wasn't configured properly.
  2. Enhancing documentation to require user to test their folder config prior to opt-ing in.

@wesfloyd
Copy link
Collaborator Author

wesfloyd commented Apr 3, 2024

Modified this PR to only include the docs changes. @shrimalmadhur or @siddimore or @ian-shim please review when ready. Thank you.

Moving the docker-compose changes to #92 for testing "when we have time"

@wesfloyd wesfloyd marked this pull request as ready for review April 3, 2024 12:54
@wesfloyd wesfloyd changed the title Enhance Docker Compose Volume Mounts: Read-Only Consistent Enhance Docs: minimize errors related to docker volumes mounted as directories Apr 3, 2024
@shrimalmadhur shrimalmadhur merged commit 4982d12 into master Apr 3, 2024
@shrimalmadhur shrimalmadhur deleted the wf-enhance-volume-ro-consistent branch April 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants