Merge pull request #18 from pemberton-rank/feedback-ui-dismiss-behavior

feedbackform support plain dismiss action
Layer-One-Capital · Aug 26, 2019 · 7da972c · 7da972c
2 parents 162779f + 453d6aa
commit 7da972c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/lib/index.js b/lib/index.js
diff --git a/lib/index.js.map b/lib/index.js.map
diff --git a/src/components/forms/FeedbackForm.js b/src/components/forms/FeedbackForm.js
@@ -6,7 +6,7 @@ const DISMISSED_VAL = 'dismissed'
 export default class FeedbackForm extends React.Component {
   static propTypes = {
     question: React.PropTypes.string.isRequired,
-    helpLink: React.PropTypes.string.isRequired,
+    helpLink: React.PropTypes.string,
     buttonTextYes: React.PropTypes.string,
     buttonTextNo: React.PropTypes.string,
     repeating: React.PropTypes.bool,
@@ -57,13 +57,22 @@ export default class FeedbackForm extends React.Component {
           className="customer-feedback__form__btn--yes"
           onTouchTap={() => this.handleClick('yes')}
         />
-        <a target="_blank" href={helpLink} onClick={() => this.handleClick('no')}>
+        {helpLink ? (
+          <a target="_blank" href={helpLink} onClick={() => this.handleClick('no')}>
+            <Button
+              label={buttonTextNo}
+              buttonType="secondary"
+              className="customer-feedback__form__btn--no"
+            />
+          </a>
+        ) : (
           <Button
             label={buttonTextNo}
             buttonType="secondary"
             className="customer-feedback__form__btn--no"
+            onClick={() => this.handleClick('no')}
           />
-        </a>
+        )}        
       </div>
     )
   }