Change visibility of nn::Path::add
method to public.
#910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the visibility of the
nn::Path::add
method frompub(crate)
topub
. The updated method signature is:Reason for Change
Previously, the add method was restricted to crate-level visibility (
pub(crate)
), which limited its usage. This change makes the method accessible outside the crate, enabling users to add existing tensors to aVarStore
.Use Case
While implementing Python bindings, I needed to add tensors from Python to
VarStore
. Making the add method public makes this possible.