Minecraft 1.13 - Datapacks #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmess1221
reviewed
Jan 6, 2018
| Stream<LanternResource> stream = null; | ||
| try { | ||
| // If a wildcard is used, there is some special handling required | ||
| if (path1.getNamespace().isEmpty()) { |
There was a problem hiding this comment.
This will never be empty. If the namespace is omitted from vanilla, minecraft is used in its place.
e.g. :. will become minecraft:.
There was a problem hiding this comment.
We could modify that behavior? Or use a wildcard like * instead.
mattmess1221
reviewed
Jan 6, 2018
| final Matcher matcher = NAMESPACE_PATH_PATTERN.matcher(path); | ||
| checkState(matcher.matches(), | ||
| "%s doesn't match the namespaced path pattern: %s", path, NAMESPACE_PATH_PATTERN.pattern()); | ||
| this.namespace = matcher.group(1); |
There was a problem hiding this comment.
How does this handle a non-existent namespace? By non-existent, I mean missing, which should default to minecraft.
There was a problem hiding this comment.
Non existent would be path/to/file, wildcard namespace :path/to/file
There was a problem hiding this comment.
I haven't currently implemented path/to/file support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the WIP datapacks API
SpongePowered/SpongeAPI#1706
Different kind of paths:
path/to/file.txtThe namespace is unknown and will default tominecraft:path/to/file.txtpath/to/directoryThe namespace is unknown and will default tominecraft:path/to/directory:path/to/file.txt(*:path/to/file.txt) The namespace is a wildcard, alternatively use*as namespace. Matches the first/all the files with the given path for every available namespace.:path/to/directory(*:path/to/directory) The namespace is a wildcard, alternatively use*as namespace. Matches the all the files within the given directory for every available namespace.namespace:path/to/file.txtA regular namespaced file path.namespace:path/to/directoryA regular namespaced directory path.