Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile #333

Closed
wants to merge 3 commits into from
Closed

Makefile #333

wants to merge 3 commits into from

Conversation

natct10
Copy link
Member

@natct10 natct10 commented Apr 1, 2021

You can use make black, make flake, make tests, make tests-ml-perf and make test-contrib. Please install make to test.
Windows users might use chocolatey package manager: https://chocolatey.org/packages/make.

Started here: #319
Fix #312

Copy link
Member

@bowni bowni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thing in principle. But I would have a couple remarks:

  1. Could we remove the black formatter? I really don't like the syntax it gives, it makes code files difficult to read

  2. As discussed this morning, I am not too sure about end-to-end tests on this one, it might take a while, and become useless because of that. I think flake + unit tests would be a good combo, both handy and useful

@bowni bowni added the enhancement New feature or request label Apr 2, 2021
@natct10
Copy link
Member Author

natct10 commented Apr 2, 2021

Cool thing in principle. But I would have a couple remarks:

1. Could we remove the black formatter? I really don't like the syntax it gives, it makes code files difficult to read

Black is a great tool. And you don't have to accept all, git add -p is useful in this regard.

2. As discussed this morning, I am not too sure about end-to-end tests on this one, it might take a while, and become useless because of that. I think flake + unit tests would be a good combo, both handy and useful

This part is refined in this PR: https://github.com/SubstraFoundation/distributed-learning-contributivity/pull/336/files. The idea was -even if the command takes a long time to be executed- to have an alias to run it.

Let me know

Copy link
Member

@bowni bowni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 @natct10

@natct10
Copy link
Member Author

natct10 commented Apr 6, 2021

Closing as it is included in 336

@natct10 natct10 closed this Apr 6, 2021
@bowni bowni deleted the makefile branch November 3, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add make build & make tests
2 participants