-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile #333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thing in principle. But I would have a couple remarks:
-
Could we remove the black formatter? I really don't like the syntax it gives, it makes code files difficult to read
-
As discussed this morning, I am not too sure about end-to-end tests on this one, it might take a while, and become useless because of that. I think flake + unit tests would be a good combo, both handy and useful
Black is a great tool. And you don't have to accept all,
This part is refined in this PR: https://github.com/SubstraFoundation/distributed-learning-contributivity/pull/336/files. The idea was -even if the command takes a long time to be executed- to have an alias to run it. Let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 @natct10
Closing as it is included in 336 |
You can use
make black
,make flake
,make tests
,make tests-ml-perf
andmake test-contrib
. Please installmake
to test.Windows users might use chocolatey package manager: https://chocolatey.org/packages/make.
Started here: #319
Fix #312