-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Roman prism and grism bands #104
base: main
Are you sure you want to change the base?
Conversation
Now that GalSim v2.6 is released, this PR is ready to be reviewed and merged. Should we require |
galsim (and many other packages) are not listed in pyproject.toml because, for the most part, skyCatalogs is used in the context of LSST Science Pipelines, which includes galsim. Recent builds of LSST Science Pipelins are at galsim version 2.5.3. I don't want to put in a requirement which is necessary only for Roman and troublesome for Rubin unless there is a way to signal that it should apply only when requested. If that's not possible your code could check the galsim version and behave accordingly. |
Ah, that's a fair point. Btw, is there any expectation that |
Generally speaking yes, it should be compatible with older versions of |
Addresses #103 .
This is currently a draft PR since I think some upstream changes in GalSim may be required as well. Are there any tests that I should include in the mean time?