Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First try at tom + resspect GHA #81

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

First try at tom + resspect GHA #81

wants to merge 3 commits into from

Conversation

mtauraso
Copy link
Collaborator

@mtauraso mtauraso commented Nov 20, 2024 •
edited
Loading

A github actions script that reproducibly launches TOM + Resspect docker env.

@mtauraso mtauraso marked this pull request as ready for review November 20, 2024 20:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Before [93de907] After [3c86dd6] Ratio Benchmark (Parameter)
139±5ms 143±4ms 1.03 benchmarks.time_feature_creation
155±2ms 159±3ms 1.03 benchmarks.time_learn_loop('KNN', 'UncSampling')
151±1ms 153±2ms 1.01 benchmarks.time_learn_loop('KNN', 'RandomSampling')
2.59±0.01s 2.58±0.02s 1 benchmarks.time_learn_loop('RandomForest', 'UncSampling')
197M 195M 0.99 benchmarks.peakmem_learn_loop('KNN')
188M 186M 0.99 benchmarks.peakmem_learn_loop('RandomForest')
2.60±0.04s 2.58±0.02s 0.99 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')

Click here to view all benchmarks.

@mtauraso mtauraso self-assigned this Nov 20, 2024
@mtauraso
Adding a version of tom test that works locally.
c7cb2ed 
- Bootstrap test/train/validate features
- Bind mounting of a work dir in dockerfile
- Test scripts to run one night of training
- Compose configuration to work with TOM
- Github action script to run full flow int TOM test env

Pair coded with @AmandaWasserman
mtauraso
mtauraso commented Nov 22, 2024
View reviewed changes
src/resspect/time_domain_loop.py
req = { 'requester': requester,
'objectids': objectids,
'priorities': priorities}
res = tom.request( 'POST', 'elasticc2/askforspectrum', json=req )
print(res)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove these lines

mtauraso
mtauraso commented Nov 22, 2024
View reviewed changes
src/resspect/scripts/make_train_test_val.py
@@ -0,0 +1,164 @@
import resspect
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO document that this script is the source of TOM_*_features files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rknop rknop Awaiting requested review from rknop

@AmandaWasserman AmandaWasserman Awaiting requested review from AmandaWasserman

At least 1 approving review is required to merge this pull request.

Assignees

@mtauraso mtauraso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtauraso